@elextr approved this pull request.
LGBI except for one query.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser *self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must exist on disk */
+ if (! doc || ! doc->real_path)
+ return FALSE;
+
+ uri = g_strconcat ("file://", doc->file_name, NULL);
Why test doc->real_path above and use untested doc->file_name here? Shouldn't
this use the path?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#pullrequestreview-2023836790
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1295/review/[email protected]>
