This is an experiment to use GtkFileChooserNative on Windows and macOS to address issues like
https://github.com/geany/geany-osx/issues/14 where the GTK dialogs don't offer the best user experience. I kept using GtkFileChooser on Linux because it adds extra widgets to the dialog like file encoding and filetype selection and these aren't supported when using native dialogs. To me at least this isn't the most important thing and using native dialogs under Windows and macOS is more important IMO. This leads to a few ifdefs in the code but I'd say the result isn't too bad (GtkFileChooser is a GtkWidget while GtkFileChooserNative isn't so some things have to differ). Before continuing with the save dialog and project open dialog, my question is whether something like that would be acceptable for Geany - @b4n @eht16 what do you think? @eht16 Do the native dialogs work correctly on Windows with this patch? It seems to work alright on macOS. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3861 -- Commit Summary -- * Use GtkFileChooserNative for opening files on Windows and macOS -- File Changes -- M src/dialogs.c (75) -- Patch Links -- https://github.com/geany/geany/pull/3861.patch https://github.com/geany/geany/pull/3861.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3...@github.com>
