> Sorry, I wasn't clear, many of the custom filetypes have no parser and don't 
> crash. So what do they set the tag_parser to? 

The crash only happened because Geany was trying to load the global tags file 
for Python (`data/tags/std.py.tags`) and it was Python for which I set 
`tag_parser=`. The custom filetypes that don't use  `tag_parser` also set the 
parser to `TM_PARSER_NONE` but don't have any global tags file so the crash 
doesn't happen for them.

I could have also fixed this particular crash by checking the parser for 
`TM_PARSER_NONE` inside e.g. `tm_workspace_load_global_tags ()` but I think 
it's a good idea to protect all the ctags-interfacing functions against this 
value.

> And can tag_parser= be set to the same value that successfully works for 
> custom filetypes.

Well, I think we should be able to allow users disable some ctags parser if it 
e.g. causes crashes and `tag_parser=` is the way to do it currently. And 
setting the parser of say the Pascal filetype to the C parser isn't a good idea 
as the C parser will be constantly confused by Pascal sources.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3865#issuecomment-2094788766
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3865/c2094788...@github.com>

Reply via email to