@techee requested changes on this pull request.
Looks good. There's just the minor formatting issue plus I noticed that right
now there's a merge conflict, probably because of the other vimode PR I merged
- would you have a look at that?
You can just squash the result into one commit, I don't expect any more
problems.
> @@ -306,6 +306,14 @@ gboolean vi_notify_sci(SCNotification *nt)
}
}
+ if (nt->nmhdr.code == SCN_MARGINCLICK) {
Maybe just { on a separate line.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1349#pullrequestreview-2071593860
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1349/review/[email protected]>