@b4n commented on this pull request.


> @@ -152,6 +152,8 @@ Section "Dependencies" SEC04
 SectionEnd
 
 Section -Post
+       Exec '"$INSTDIR\bin\glib-compile-schemas.exe" 
"$INSTDIR\share\glib-2.0\schemas"'

How does this behave if the executable is missing?  If it is mandatory, then 
maybe mark the dependency somehow?
Also, has `$INSTDIR` has to be the same as Geany's?  If not, we won't find the 
executable here, will we?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1352#pullrequestreview-2078994996
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1352/review/[email protected]>

Reply via email to