@techee commented on this pull request.


> @@ -324,6 +339,18 @@ static gboolean on_editor_button_press_event(GtkWidget 
> *widget, GdkEventButton *
                                keybindings_send_command(GEANY_KEY_GROUP_GOTO, 
GEANY_KEYS_GOTO_MATCHINGBRACE);
                        return TRUE;
                }
+               if (event->type == GDK_BUTTON_PRESS && event->state == 
GDK_MOD1_MASK)

> don't use event->state directly (at least not when comparing to equality), 
> because it can contain a whole lot of problematic things (numlock state, 
> etc.). Luckily, there's state already available here :)

Yes, but `keybindings_get_modifiers()` filters-out Alt (`GDK_MOD1_MASK`) I 
wanted to use.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3899#discussion_r1632404808
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3899/review/[email protected]>

Reply via email to