> > why did you choose against icons? Maybe we can try to match some of
the Makefile mapping, e.g. "targets" seem to have a similar meaning.
>
> It's not because of the icons themselves but because there's no
clear semantic mapping of the kinds provided by meson and icon names (which are
tailored to programming languages) - so I wasn't sure what to use. If you
have some suggestions which icons to use for which kinds, no problem to add
them.
I'm not sure either, maybe:
```c
static TMParserMapGroup group_MESON[] = {
{N_("Projects"), TM_ICON_CLASS, tm_tag_namespace_t},
{N_("Modules"), TM_ICON_NAMESPACE, tm_tag_package_t},
{N_("Variables"), TM_ICON_NONE, tm_tag_variable_t},
{N_("Subdirs"), TM_ICON_OTHER, tm_tag_macro_t},
{N_("Build Targets"), TM_ICON_METHOD, tm_tag_other_t},
{N_("Custom Targets"), TM_ICON_METHOD, tm_tag_enumerator_t},
{N_("Benchmark Targets"), TM_ICON_METHOD, tm_tag_function_t},
{N_("Run Targets"), TM_ICON_METHOD, tm_tag_member_t},
{N_("Tests"), TM_ICON_NONE, tm_tag_field_t},
};
```
- Modules -> TM_ICON_NAMESPACE: as modules here are somewhat similar to
imports in Python, so use the same icon as in Python
- *Targets -> TM_ICON_METHOD: same semantic as in Makefile, so use the same
icon as there
- the others are just to be filled and "Tests" left empty (assuming
most Meson files won't have tests :D)
But as you see, this is also more or less arbitrary. We don't need to add
them at all.
> > is it useful to list the variables as symbols? This can get many
quickly, I tested with GLib's meson.build and there the list is pretty long.
>
> OK, these can be removed (or mapped to local variables which aren't
shown in the sidebar so symbol goto still works for them).
:+1:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4013#issuecomment-2452284179
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4013/[email protected]>
