> ok got it about real_path, not sure about > document_new_file_with_creation_type but anyway i guess we are not doing > these changes as i wont be able to introduce new logic like detecting > modifications etc. So this means templates issues is out of question, closing that PR.
To me it doesn't sound too difficult so I'll try to do it myself once this PR is merged. But of course on the way I can realize it's not so easy as I imagine and may decide it's not worth it. > Which leads us to the last open question - since templates are not working - > what to do with geany.txt from another PR - should i remove mentions of > templates from Untitled Document Save section, or move it back to Instant > Save or just keep as is? Since this is a separate PR, I'd say let's wait if I manage to implement it in which case we can keep it; otherwise we can drop it. >> I don't care much, you can post it afterwards too. > Then i'll just create another PR after this one is merged >> I'm slightly lost in what you are proposing here - as I said, I think it can >> wait until this PR is merged. > I proposed to add those changes right to this PR, but doesnt matter, i'll > create another PR after this one is merged In the light of the above, I think it would actually be best if you added both of the fixes to this PR so I can start the work on the finished result. I think you can keep these as separate commits (no rebasing needed). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3911#issuecomment-2504626664 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3911/[email protected]>
