At the moment, when "Always wrap search" and "Hide the find 
dialog" are disabled in preferences, after performing wrap and dismissing 
the wrap dialog, the editor is focused instead of the search/replace dialog 
again. This interrupts keyboard-based user interaction with the dialog as users 
have to manually re-focus the search/replace dialog.

I haven't found a way to re-focus the search/replace dialog without hiding 
it first. But I actually think hiding the search/replace dialog when the wrap 
dialog is shown is a cleaner UI than having the two dialogs on top of each 
other.

Fixes #4021.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/4096

-- Commit Summary --

  * Move show_wrap_search_dialog() to search.h
  * Hide find/replace dialogs when wrap dialog is shown
  * Remove parent argument from document_find_text() and 
search_show_wrap_dialog()

-- File Changes --

    M src/document.c (46)
    M src/document.h (2)
    M src/search.c (59)
    M src/search.h (2)

-- Patch Links --

https://github.com/geany/geany/pull/4096.patch
https://github.com/geany/geany/pull/4096.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4096
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4...@github.com>

Reply via email to