**Problem 1** In Czech for instance, the "In Session" button is translated as "Ve všech otevřených souborech" (meaning "in all open files"). Since the sizing of buttons is homogenous, all of them pick this size (including the "close window" checkbox on the left) and the result is a ridiculously wide search dialog that is impossible to shrink for users:
<img width="1070" alt="Screenshot 2024-12-05 at 19 51 16" src="https://github.com/user-attachments/assets/8c83ab2b-c1d2-4c2e-90e9-22f1a0221657"> I dropped the homogenous spacing but to simulate it, I set the minimum size of all the buttons to 130px so buttons containing shorter labels (which are most of them in practice) still have the same size. The result looks much more reasonable: <img width="670" alt="Screenshot 2024-12-05 at 20 01 51" src="https://github.com/user-attachments/assets/172cff1b-4e86-41ee-98cb-e795790a23d3"> **Problem 2** In German, for instance, a translation in the first column of checkboxes is much wider than in the second column but again, the two columns are sized homogeneously so there is a lot of wasted space in the second column. <img width="863" alt="Screenshot 2024-12-05 at 19 56 50" src="https://github.com/user-attachments/assets/d492887f-f0b8-4f4f-aac3-9b92ee91b00d"> The second patch drops the homogenous spacing so the second column can be shorter: <img width="670" alt="Screenshot 2024-12-05 at 20 02 53" src="https://github.com/user-attachments/assets/707961dc-ffb5-4efb-b848-d5a22ff35a34"> **Problem 3** Finally, I noticed that the vertical distance between the "Find All" expander and the "Close dialog" checkbox below it is too low and the text looks a bit crowded. I added a 6px padding there. (Check the screenshots above to see the before/after change.) You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/4098 -- Commit Summary -- * Drop homogenous spacing of additional buttons in search/replace dialog * Drop homogenous sizing for checkbox buttons * Add padding between the "Find all" expander and "Close dialog" below it -- File Changes -- M src/search.c (90) -- Patch Links -- https://github.com/geany/geany/pull/4098.patch https://github.com/geany/geany/pull/4098.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4098 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/[email protected]>
