@eht16 commented on this pull request.


> +
+        gtk_widget_show_all(vbox);
+        g_signal_connect(dialog, "response", 
G_CALLBACK(on_configure_response), NULL);
+
+       return vbox;
+}
+
+
+void plugin_init (GeanyData *data)
+{
+       GeanyKeyGroup *key_group;
+
+       load_config();
+
+       key_group = plugin_set_key_group (geany_plugin, "incdec", KB_COUNT, 
on_change_number_callback);
+       keybindings_set_item (key_group, KB_INCREMENT_NUMBER, NULL, 
GDK_KEY_KP_Add, GDK_SHIFT_MASK,

GDK_KEY_KP_Add is specific for the + key on the numpad, I think.

The ReadMe mentions Shift-+ and this does not work on my system (German 
keyboard).
I think this won't work on most keyboard layouts where +, - and * are 
interpreted with Shift to another key.
So, maybe just make the README (and possibly other references) more explicit.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1351#pullrequestreview-2530897176
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1351/review/2530897...@github.com>

Reply via email to