> > Thanks, I really should have a look. It'll probably take only a few more > > months or so :). > > Just saying :-). If nothing else, seeing syntax errors underlined in the > editor in the real time without the need to perform actual compilation is a > big productivity boost for me.
Well, the latest commits are "geany-lsp" powered :). It works quite nice, so far even without an active project :D. > The patch is below (created very quickly by reusing code from `kb_update()` > for the update function, possibly needs improving). This is awesome and much simpler than I expected. When writing the initial code I shortly thought about using the store to remember the visibility state but then dropped that idea because I imagined the implementation way more complicated. Thanks for pointing me that I was wrong :). > I went through the code and looks good to me (note I'm not Colomban though > ;-). In addition to the above patch, maybe two additional > functionality-related notes: > > 1. I think it would be good to filter also based on the group name - e.g. > if I want all "git changebar" settings and type "git", all its children would > be shown. Implemented, based on your filter approach this was quite easy. > 2. I find it a bit strange that the filter text in the entry is preserved > after closing and reopening the Preferences dialog. Wouldn't it be better to > clear it? Oops, didn't notice it. Fixed by clearing the entry text on dialog open and while at it I found also that I connected the signals to the entry each time the dialog was open, not when it was created. Also fixed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4192#issuecomment-2585730308 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4192/c2585730...@github.com>