@b4n commented on this pull request.
> +SOURCE_DIR = join(os.environ['HOME'], 'git', 'geany') +BUILD_DIR = join(os.environ['HOME'], 'git', 'geany', '_build') +RELEASE_DIR_ORIG = join(BASE_DIR, 'release', 'geany-orig') +RELEASE_DIR = join(BASE_DIR, 'release', 'geany') +BUNDLE_BASE_DIR = join(BASE_DIR, 'bundle') +BUNDLE_GTK = join(BASE_DIR, 'bundle', 'geany-gtk') +GEANY_THEMES_URL = 'https://github.com/geany/geany-themes/archive/refs/heads/master.zip' +GEANY_THEMES_DIR = join(BUNDLE_BASE_DIR, 'geany-themes') +INSTALLER_NAME = join(BASE_DIR, f'geany-{VERSION}_setup.exe') + +# signing params +SIGN_CERTIFICATE = join(BASE_DIR, 'codesign.pem') # adjust to your needs +SIGN_CERTIFICATE_KEY = join(BASE_DIR, 'codesign_key.pem') # adjust to your needs +SIGN_WEBSITE = 'https://www.geany.org' +SIGN_NAME = 'Geany Binary' +SIGN_TIMESTAMP = 'https://zeitstempel.dfn.de/' After a bit of research this looks probably OK, but without further explanation it looks *so* shady it'd be good to explain it. @eht16 can probably help here(?) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4223#pullrequestreview-2588383718 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4223/review/2588383...@github.com>
