b4n left a comment (geany/geany#4081) OK so I have given this a spin, and I have 3 remarks:
* I couldn't yet find anything it mishighlights (at least not related to the changes here), so that looks good. * We should probably set `lexer.bash.styling.inside.heredoc=1` as well * I'm not sure I *really* like `lexer.bash.styling.inside.string=1`. Yes, it's great when there are complex expansions. But I find it lowers usability when quoting single variables, which is overly common, as it makes the fact it's quoted a lot harder to notice. I guess ideally there'd be a way to highlight these slightly differently, like command substitution if we supported `lexer.bash.command.substitution=2`, but for strings as well. As is, I'm afraid it makes it harder to spot missing quoting. This said, I'm not against giving this a shot if others like it as is. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4081#issuecomment-2867809113 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4081/[email protected]>
