b4n left a comment (geany/geany-plugins#1458)

I didn't test this, but 2 questions:
* can't we simply use hardware keycodes from the keymap? I understand fallback 
*may* (or may not) be harder to have, but does it actually matter? Is it a 
realistic situation not to find the keycodes, and is the fallback actually 
better? My thought is that as we care about the physical key, it would make 
more sense.
* isn't there a signal on keymap change that could be used instead of figuring 
this again and again for all key presses?

Apart from this, looks reasonable from the little I know about keymaps.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1458#issuecomment-3018929251
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1458/c3018929...@github.com>

Reply via email to