@xiota commented on this pull request.
> ) + AC_MSG_CHECKING([for Lua version]) + LUA_VERSION=`$PKG_CONFIG --modversion $LUA_PKG_NAME 2>/dev/null` + + if test -n "$LUA_VERSION"; then + AC_MSG_RESULT([$LUA_VERSION]) + case "$LUA_VERSION" in + 5.1*|5.2*|5.3*) + AC_MSG_WARN([Lua version $LUA_VERSION is EOL. Consider upgrading.]) This is mainly to address @techee concern of supporting too many Lua versions. While I have no definite plans to drop (building with) Lua 5.1, I do consider Lua 5.4 and LuaJIT to be the preferred implementations after this PR. The message could be made stronger, "Lua version __ is EOL and unsupported." But I don't want to stop people from actually using whatever version they choose until incompatible changes become necessary. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238#discussion_r2187518350 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1238/review/[email protected]>
