@techee commented on this pull request.
> @@ -38,6 +38,10 @@ #include <glib.h> #include <glib/gprintf.h> +#ifndef G_GNUC_FALLTHROUGH +# define G_GNUC_FALLTHROUGH /* GLib < 2.60 */ +#endif Ah, no, the comment wasn't related to this case. It was related e.g. to Geany's `utils_get_os_info_string()` which contains code like ```C #if GLIB_CHECK_VERSION(2, 64, 0) ... g_get_os_info(); /* warning here */ ... #endif ``` Even though this code is completely legal and protects the use of `g_get_os_info()`, you get a warning for the use of `g_get_os_info()` when using `GLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56`. This way you get a warning for every newer API use no matter whether it's within the version check block or not. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1479#discussion_r2202454855 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1479/review/3012853...@github.com>
