@b4n commented on this pull request.


>              mingw-w64-x86_64-gtk3
             mingw-w64-x86_64-python-docutils
             patch
             rsync
             unzip
             dos2unix
             mingw-w64-x86_64-nsis
+      # build the GTK bundle, but cache it for a week
+      - name: cache timestamp for GTK-Bundle
+        id: cache_gtk_bundle_timestamp
+        run: echo "timestamp=$(date +%Y-%U)" >> $GITHUB_OUTPUT

> Given we usually release on Sundays, I should use a date that changes on 
> Mondays rather, so we have a chance to test the actual bundle beforehand.

Fixed by using `%W` instead of `%U`.

> Maybe a way to force rebuilding it as well could be nice (e.g. some job input)

Thinking about it a bit more, that doesn't actually seem useful: either the 
cache is good, or we're gonna want to delete it anyway; and there's already UI 
(and API) to delete cache items, and no way to update an existing cache, so an 
input couldn't be "force updating the cache".  So, if the cache is bad or older 
than wanted, just delete it and trigger a new run.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4484#discussion_r2615482085
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4484/review/[email protected]>

Reply via email to