b4n left a comment (geany/geany#4414) > > I couldn't help myself and "fixed" the cross build by reverting back to > > mingw64 for it. I guess we could also fix it by adjusting the docker > > environment to include the ucrt64 packages instead of the mingw64 ones. > > Why do you spend time on it at all?
OCD that a PR must not break things that are working? :smile: Anyway, I think the change I introduced is not bad; it allows for the bundle script to adjust to the requested runtime, which potentially could be useful either if we want to switch in the future, or if others want to tests stuff with other ones. Not necessary, but I'm fairly happy with it. > > @eht16 BTW does the Windows nightlies succeed entirely? I'm still wondering > > why the test fails on the GA environment; and if it works on the nightlies > > one it could be interesting to see why -- and if it doesn't, do those fail > > since a long time? > > The nightly cross-builds fail in the same way for quite some time already. OK. I'm a bit puzzled to why we can't run installed binaries, especially as I have a similar issue on the native builds, but as @giuspen tested the installers successfully it's probably nothing. Yet, I'd love to have a confirmation, because I'm not sure anybody tested since it started failing, did somebody? > As said above and also in the other PR already, I don't want to spend any > time on debugging and fixing this and instead use the native CI build you are > working on. > > I started writing a script to query the status of the latest native Windows > CI build via the Github API and use this information for the nightly builds > instead of actually building the code. Same for the resulting artifact. But I > probably need a few more days to finish it. Cool :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4414#issuecomment-3649542948 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4414/[email protected]>
