advice2020 left a comment (geany/geany-plugins#1560)

@Skif-off
WTF! Skkkiiiiiiffffffff! This works great!
I have been receiving 0 responses for most of my application based posts for so 
long, it is nice to actually get a productive response from someone :)
As I mentioned it has been lonely out here, not many projects that are 
interested in my suggestion posts :) and not even bug reports :)
but you are always so helpful when our paths cross, as mentioned I really 
appreciate it.
I was not sure if this was going to be possible in the way that I was asking 
for but you were able to do it, everything overall works very smooth.
As mentioned I am glad you were able to figure out a way to go with this more 
manual approach, rather then Geany having to check each open/close using events 
folder feature, for this use case.

I do have some minor questions/observations/possible updates to mention but 
none are really needed.

-------------------------------------------------------------------------------------------------

POSSIBLE UPDATES

1.) (Would not update scripts in this post you made for this)
Not important, I plan on using the bookmark.txt file in Geany .config folder 
location, but if for some reason I/other users wanted to change location in the 
future, would there be an easy way to achieve this?
I assume it has something to do with one of these lines
```
local sD = geany.appinfo().configdir
local sBF = sD .. geany.dirsep .. "bookmarks.txt"
```
I tried a couple things of removing some text and trying to replace with 
specific paths but everything I tried generated errors because I do not know 
what I am doing :)

-------------------------------------------------------------------------------------------------

2.) (Would update script in this post you made, if this is possible/you agree 
and are willing to change it)
Most users are probably not going to open the "bookmarks.txt" file itself, but 
I like the idea of being able to make manual modifications to this file if 
desired.
I noticed that the bookmark numbers that are saved are -1 of the actual line 
number the bookmark is added to.
For example if a file has a bookmark on line 7, the "bookmarks.txt" file shows 
the number 6 instead.
Would there be a way to somehow make the "bookmarks.txt" file show the actual 
line number the bookmarks are on?

-------------------------------------------------------------------------------------------------

3.) (If above update is made to scripts, then maybe would consider making this 
update as well if already going to be making an update to this Github post)
I can easily change this in the script on am using on my machine, but this 
might be helpful to other users if agree.
In the `bookmarks-load.lua` script
It contains the following warning dialog text
`The list of files with bookmarks not found.`
This might get slightly misinterpreted by some
Maybe would consider changing this to something like
`Bookmark file not found`

-------------------------------------------------------------------------------------------------

Some of these may be minor / not needed by other users, but I would be 
interested in them if they are easy enough items to answer/update.

Again thank you for creating these scripts, these are really great, very happy 
with the results you were able to achieve.




-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1560#issuecomment-4711843679
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/issues/1560/[email protected]>

Reply via email to