WrapEarnPass left a comment (geany/geany#4603) Confusion, Yes. https://www.geany.org/manual/reference/pluginsignals_8c.html is ever so slightly different from https://www.geany.org/manual/reference/signals.html > Sent when a project is saved (happens when the project is created, the > properties dialog is closed, before the project is closed, when Geany > automatically saves its configuration by opening/closing documents or when > Geany is exited).
versus >Sent when a project is saved(happens when the project is created, the >properties dialog is closed or Geany is exited). This signal is emitted >shortly before Geany will write the contents of the GKeyFile to the disc. Neither of them note that by default save_config_on_file_change will cause project-save from a document-save. Real issues? Meh. Though, Debian did just rip out their entire /tmp implementation to move it all to tmpfs for the stated reason of ~"Stop pointless writes to SSDs" https://linuxiac.com/debian-13-moves-to-tmpfs-for-tmp-directory/ How many plugins are spinning their wheels project-loading on each file save? ``` ./geanyctags/src/geanyctags.c: {"project-save", (GCallback) & on_project_save, TRUE, NULL}, ./lsp/src/lsp-main.c: {"project-save", (GCallback) &on_project_save, FALSE, NULL}, ./autorun/src/plugin_main.c: { "project-save", (GCallback)&on_project_save, TRUE, NULL }, ./geanylua/glspi_init.c: {"project-save", (GCallback) &on_proj_save, TRUE, NULL}, ./projectorganizer/src/prjorg-main.c: {"project-save", (GCallback) & on_project_save, TRUE, NULL}, ``` That's a rather large impact. I count 48 plugins total, so just short of 10% hook project-save. And ctags is already slow, I know geanyctags could use that help. I have been running with save_config_on_file_change=false for a a few days now. I have been crashing my geany/2.2 build. A lot. A loooot. I have not noticed any data loss in Project. Maybe, maybe it forgot a file I opened right before I crashed it. Considering that #2114 was against 1.37, 7 years ago, and did not specifically mention document-save in the bug report >Save main and project configuration whenever documents are opened/closed I would suggest: save_config_on_file_change to default false update documentation to note that project-save may be caused by document-save IF save_config_on_file_change is enabled. At the very least, documentation to mention save_config_on_file_change influences project-save. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4603#issuecomment-4789427328 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/issues/4603/[email protected]>
