WrapEarnPass left a comment (geany/geany#4615)
@eht16 I do not understand your question.
> Did you build Geany without those flags and were able to use it without
> limitations?
I am not advocating for nor requesting removal of the flags.
I am proposing ensuring that all binaries build with uniform flags by moving
the define from
src/win32.c to ```CFLAGS="-D_WIN32_WINNT=0x0601 ${CFLAGS}"``` so that all
windows binaries get the same flag and not just the win32.c file.
_WIN32_WINNT isn't really meant to be a static flag, but a compile time flag.
src/win32.c is not wrong, it is just stale, and if a developer builds using
compile time options like ```CFLAGS="-D_WIN32_WINNT=0x0601 ${CFLAGS}"``` it
pops up as a redefine warning.
[Mirocfot](https://learn.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170)
even notes this.
> When you upgrade an older project, you may need to update your WINVER or
> _WIN32_WINNT macros. If they're assigned values for an unsupported version of
> Windows, you may see compilation errors related to these macros.
If the defines are in the build command, there is no need to edit file(s) to
set it to a more modern value, or if needed for some reason to an ancient one.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/4615#issuecomment-4948417311
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/4615/[email protected]>
