WrapEarnPass left a comment (geany/geany-plugins#1570) Plenty of plugins, which all build in the existing geany environment, definitively above GTK 3.0.0, check for it anyway. ``` ./utils/src/gp_gtkcompat.h:#if GTK_CHECK_VERSION(3, 0, 0) ./utils/src/gp_gtkcompat.h:#if GTK_CHECK_VERSION(3, 10, 0) ./utils/src/gp_gtkcompat.h:#if GTK_CHECK_VERSION(3, 8, 0) ./debugger/src/dconfig.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if !GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if !GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.c:#if !GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererframeicon.h:#ifndef __CELL_RENDERER_FRAME_ICON_H__ ./debugger/src/cell_renderers/cellrenderertoggle.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrenderertoggle.h:#ifndef __CELL_RENDERER_TOGGLE_H__ ./debugger/src/cell_renderers/cellrendererbreakicon.h:#ifndef __CELL_RENDERER_BREAK_ICON_H__ ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if !GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if !GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if !GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/cell_renderers/cellrendererbreakicon.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/plugin.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/tpage.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/debug.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/debug.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/debug.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/debug.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/btnpanel.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/btnpanel.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/btnpanel.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/btnpanel.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/btnpanel.c:#if GTK_CHECK_VERSION(3, 0, 0) ./debugger/src/gui.c:#if GTK_CHECK_VERSION(3, 0, 0) ``` Checking for an ABI feature before adding code for it is fairly common for C.
Just like git-changebar cares about if which version of libgit is available to add/change feature code. ``` ./git-changebar/src/gcb-plugin.c:#if ! CHECK_LIBGIT2_VERSION(0, 22) ./git-changebar/src/gcb-plugin.c:#if ! CHECK_LIBGIT2_VERSION(0, 23) ./git-changebar/src/gcb-plugin.c:#if ! CHECK_LIBGIT2_VERSION(0, 28) ./git-changebar/src/gcb-plugin.c:#if ! CHECK_LIBGIT2_VERSION(0, 99) ./git-changebar/src/gcb-plugin.c:#if ! CHECK_LIBGIT2_VERSION(1, 4) ./git-changebar/src/gcb-plugin.c:#if ! CHECK_LIBGIT2_VERSION(1, 4) ``` And, as the file is breaking in this build, for only this plugin, and for no other plugins, I would believe that indicates that geanylua does care about specific geany versions. The fact that I can add that check, and build the entire geany-plugins/master for 2.1 seems to indicate that pinning to a specific version of geany for the whole build process isn't the correct behavior. Based on the fact that fixes for geanylua from geany-plugins/2.1.0 are going into [geanylua](https://github.com/geany/geany-plugins/commits/master/), it appears that geany-plugins/master isn't tracking a potential new geany-plugins version, but fixes. geanylua/glspi_keycmd.h is checked in. It is not regenerating on build. Is a build task missing? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1570#issuecomment-4957456918 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/issues/1570/[email protected]>
