pitrou commented on issue #6981:
URL: https://github.com/apache/arrow/pull/6981#issuecomment-616424899


   Hmm, I don't think that's right. `Int96` is the physical representation of 
96-bit integers in Parquet files, and it's entirely little-endian. This means 
it should always have the same bit-representation, regardless of the platform's 
endianness.
   
   I think there are several places that need to be fixed:
   * the `Int96` tests in `parquet/arrow/arrow_reader_writer_test.cc`
   * the various `ToImpalaTimestamp` conversion functions in 
`parquet/column_writer.h`
   * the various `Int96` helper functions in `parquet/types.h`
   
   (I may be missing one or more)
   
   Note that `Int96` types are deprecated, so you may not want to lose your 
sweat over this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to