pitrou commented on a change in pull request #6966:
URL: https://github.com/apache/arrow/pull/6966#discussion_r411365701
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
[email protected]("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
[email protected]("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
[email protected]("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
[email protected]("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
Review comment:
Nit: no need to capitalize "filesystem".
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
[email protected]("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
Review comment:
"CSV"?
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
Review comment:
Nit: "Toggle"
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
Review comment:
"Arrow" everywhere
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
[email protected]("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
[email protected]("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
Review comment:
"CUDA" (or "Cuda")
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
[email protected]("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
[email protected]("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
[email protected]("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
[email protected]("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
[email protected]("--with-flight", default=None, type=BOOL,
+ help="Build with Flight rpc support.")
[email protected]("--with-gandiva", default=None, type=BOOL,
help="Build with Gandiva expression compiler support.")
[email protected]("--with-plasma", default=False, type=BOOL,
[email protected]("--with-hdfs", default=None, type=BOOL,
+ help="Build the arrow HDFS bridge.")
[email protected]("--with-hiveserver2", default=None, type=BOOL,
+ help="Build the HiveServer2 client and arrow adapater.")
[email protected]("--with-ipc", default=None, type=BOOL,
+ help="Build the arrow IPC extensions.")
[email protected]("--with-json", default=None, type=BOOL,
+ help="Build the arrow json parser module.")
Review comment:
"JSON"
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
[email protected]("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
[email protected]("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
[email protected]("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
[email protected]("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
[email protected]("--with-flight", default=None, type=BOOL,
+ help="Build with Flight rpc support.")
[email protected]("--with-gandiva", default=None, type=BOOL,
help="Build with Gandiva expression compiler support.")
[email protected]("--with-plasma", default=False, type=BOOL,
[email protected]("--with-hdfs", default=None, type=BOOL,
+ help="Build the arrow HDFS bridge.")
[email protected]("--with-hiveserver2", default=None, type=BOOL,
+ help="Build the HiveServer2 client and arrow adapater.")
[email protected]("--with-ipc", default=None, type=BOOL,
+ help="Build the arrow IPC extensions.")
[email protected]("--with-json", default=None, type=BOOL,
+ help="Build the arrow json parser module.")
[email protected]("--with-jni", default=None, type=BOOL,
+ help="Build the arrow JNI lib.")
[email protected]("--with-mimalloc", default=None, type=BOOL,
+ help="Build the arrow mimalloc based allocator.")
[email protected]("--with-parquet", default=None, type=BOOL,
+ help="Build with parquet file support.")
[email protected]("--with-plasma", default=None, type=BOOL,
help="Build with Plasma object store support.")
[email protected]("--with-flight", default=False, type=BOOL,
- help="Build with Flight rpc support.")
[email protected]("--with-compute", default=True, type=BOOL,
- help="Build with compute kernels support.")
[email protected]("--with-dataset", default=False, type=BOOL,
- help="Build with dataset support.")
[email protected]("--use-sanitizers", default=False, type=BOOL,
- help="Toggles ARROW_USE_*SAN sanitizers.")
[email protected]("--with-fuzzing", default=False, type=BOOL,
- help="Toggles ARROW_FUZZING.")
[email protected]("--use-gold-linker", default=True, type=BOOL,
- help="Toggles ARROW_USE_LD_GOLD option.")
[email protected]("--with-python", default=None, type=BOOL,
+ help="Build the arrow CPython extesions.")
[email protected]("--with-r", default=None, type=BOOL,
+ help="Build the arrow R extesions. This is not a cmake option, "
Review comment:
"extensions", "CMake"
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
[email protected]("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
[email protected]("--with-benchmarks", default=False, type=BOOL,
[email protected]("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
[email protected]("--with-examples", default=False, type=BOOL,
[email protected]("--with-examples", default=None, type=BOOL,
help="Build with examples.")
[email protected]("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
[email protected]("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
[email protected]("--with-gandiva", default=False, type=BOOL,
[email protected]("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
[email protected]("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
[email protected]("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
[email protected]("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
[email protected]("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
[email protected]("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
[email protected]("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
[email protected]("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
[email protected]("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
[email protected]("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
[email protected]("--with-flight", default=None, type=BOOL,
+ help="Build with Flight rpc support.")
[email protected]("--with-gandiva", default=None, type=BOOL,
help="Build with Gandiva expression compiler support.")
[email protected]("--with-plasma", default=False, type=BOOL,
[email protected]("--with-hdfs", default=None, type=BOOL,
+ help="Build the arrow HDFS bridge.")
[email protected]("--with-hiveserver2", default=None, type=BOOL,
+ help="Build the HiveServer2 client and arrow adapater.")
[email protected]("--with-ipc", default=None, type=BOOL,
+ help="Build the arrow IPC extensions.")
[email protected]("--with-json", default=None, type=BOOL,
+ help="Build the arrow json parser module.")
[email protected]("--with-jni", default=None, type=BOOL,
+ help="Build the arrow JNI lib.")
[email protected]("--with-mimalloc", default=None, type=BOOL,
+ help="Build the arrow mimalloc based allocator.")
[email protected]("--with-parquet", default=None, type=BOOL,
+ help="Build with parquet file support.")
Review comment:
"Parquet"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
