emkornfield commented on a change in pull request #6991:
URL: https://github.com/apache/arrow/pull/6991#discussion_r411882849



##########
File path: cpp/src/arrow/util/rle_encoding.h
##########
@@ -414,6 +414,8 @@ static inline bool IndexInRange(int32_t idx, int32_t 
dictionary_length) {
 template <typename T>
 inline int RleDecoder::GetBatchWithDict(const T* dictionary, int32_t 
dictionary_length,
                                         T* values, int batch_size) {
+  using IndexType = int32_t;

Review comment:
       I think I misunderstood the issue for the unit testing.  I guess this 
would have been caught if we had a big endian machine?  
   
   I think adding the comment with the link that @kiszk provided would still 
make sense for the casual reader?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to