andygrove commented on a change in pull request #6770: URL: https://github.com/apache/arrow/pull/6770#discussion_r413403760
########## File path: rust/datafusion/src/utils.rs ########## @@ -74,6 +74,29 @@ macro_rules! make_string { }}; } +macro_rules! make_string_from_list { + ($column: ident, $row: ident) => {{ + let list = $column + .as_any() + .downcast_ref::<array::ListArray>() + .unwrap() Review comment: `expect` would be better than `unwrap`. Using a `Result` would be better than `expect`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org