pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413810237
##########
File path: cpp/src/parquet/file_reader.cc
##########
@@ -536,6 +577,14 @@ std::shared_ptr<RowGroupReader>
ParquetFileReader::RowGroup(int i) {
return contents_->GetRowGroup(i);
}
+void ParquetFileReader::PreBuffer(const std::vector<int>& row_groups,
+ const std::vector<int>& column_indices,
+ const ::arrow::io::CacheOptions& options) {
+ // Access private methods here
+ SerializedFile* file = static_cast<SerializedFile*>(contents_.get());
Review comment:
Interesting. Do we use the polymorphism only for tests?
##########
File path: cpp/src/parquet/file_reader.cc
##########
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ = std::move(metadata);
}
+ void PreBuffer(const std::vector<int>& row_groups,
+ const std::vector<int>& column_indices,
+ const ::arrow::io::CacheOptions& options) {
+ cached_source_ =
+ std::make_shared<arrow::io::internal::ReadRangeCache>(source_,
options);
Review comment:
To be clear, I don't think this concern should block the PR, but the
docstring should warn about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
