sunchao edited a comment on pull request #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-618740530


   Yes I think it is beneficial to avoid dropping buffers with `seek`, although 
it will be nice if the `seek_relative` will be stabilized soon so we can just 
use that.
   
   > Also, I'm not sure why a Mutex was used here. Do we agree that Refcell is 
better as the whole reader is not thread safe, right ?
   
   [Originally](https://github.com/sunchao/parquet-rs/pull/49) we designed it 
this way so that we can concurrently read multiple column chunks after 
obtaining file handle from a single row group.  Since the file handle is shared 
between these we wanted to provide thread safety on top of it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to