markhildreth commented on a change in pull request #7035:
URL: https://github.com/apache/arrow/pull/7035#discussion_r417684865
##########
File path: rust/arrow/src/util/pretty.rs
##########
@@ -27,18 +27,18 @@ use prettytable::{Cell, Row, Table};
use crate::error::{ArrowError, Result};
///! Create a visual representation of record batches
-pub fn pretty_format_batches(results: &Vec<RecordBatch>) -> Result<String> {
Review comment:
Something to point out: one thing I noticed after going back was
realizing that this API could be changed from a Vec to the less specific slice
without any change necessary. Ideally, this should have been done on the last
PR (#6972) but I didn't want to hold that PR up any longer. If there are any
qualms I can undo this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
