fsaintjacques commented on a change in pull request #7073:
URL: https://github.com/apache/arrow/pull/7073#discussion_r418556583
##########
File path: cpp/src/arrow/dataset/file_base.cc
##########
@@ -221,42 +157,34 @@ Result<std::shared_ptr<FileSystemDataset>>
FileSystemDataset::Write(
filesystem = std::make_shared<fs::LocalFileSystem>();
}
- std::vector<fs::FileInfo> files(plan.paths.size());
- ExpressionVector partition_expressions(plan.paths.size(), scalar(true));
auto task_group = scan_context->TaskGroup();
-
auto partition_base_dir =
fs::internal::EnsureTrailingSlash(plan.partition_base_dir);
auto extension = "." + plan.format->type_name();
+ FragmentVector fragments;
for (size_t i = 0; i < plan.paths.size(); ++i) {
const auto& op = plan.fragment_or_partition_expressions[i];
- if (util::holds_alternative<std::shared_ptr<Expression>>(op)) {
- files[i].set_type(fs::FileType::Directory);
- files[i].set_path(partition_base_dir + plan.paths[i]);
+ if (util::holds_alternative<std::shared_ptr<Fragment>>(op)) {
Review comment:
This will be done part of ARROW-8382.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
