tvamsikalyan commented on a change in pull request #7106:
URL: https://github.com/apache/arrow/pull/7106#discussion_r420141005
##########
File path: java/vector/src/main/codegen/templates/StructWriters.java
##########
@@ -196,6 +196,15 @@ public void setPosition(int index) {
}
}
+ <#if mode="Nullable">
+ @Override
+ public void writeNull() {
+ container.setNull(idx());
+ setValueCount(idx()+1);
Review comment:
same code is present in the other writers too, so ignoring this comment
##########
File path: java/vector/src/main/codegen/templates/UnionFixedSizeListWriter.java
##########
@@ -183,7 +183,7 @@ public void write(DecimalHolder holder) {
@Override
public void writeNull() {
- writer.setPosition(writer.idx()+1);
+ writer.writeNull();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
