wesm commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r420426659
##########
File path: cpp/src/arrow/dataset/filter.cc
##########
@@ -1261,7 +1264,232 @@ Result<std::shared_ptr<RecordBatch>>
TreeEvaluator::Filter(
return batch->Slice(0, 0);
}
-std::shared_ptr<ScalarExpression> scalar(bool value) { return
scalar(MakeScalar(value)); }
+std::shared_ptr<Expression> scalar(bool value) { return
scalar(MakeScalar(value)); }
+
+// Serialization is accomplished by converting expressions to single element
StructArrays
+// then writing that to an IPC file. The last field is always an int32 column
containing
+// ExpressionType, the rest store the Expression's members.
Review comment:
Seems likely we'll want to define a (Flatbuffers?) serialization
protocol protocol for expressions in the not-too-distant future, though this
certainly works for now! =)
##########
File path: cpp/src/arrow/type.cc
##########
@@ -43,6 +43,49 @@
#include "arrow/visitor_inline.h"
namespace arrow {
+
+constexpr Type::type NullType::type_id;
Review comment:
This seems like a quirk due to the use of `ARROW_EXPORT`, would I be
correct that this issue would not occur without the export/import business?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
