eerhardt commented on a change in pull request #7104:
URL: https://github.com/apache/arrow/pull/7104#discussion_r420422699
##########
File path: docker-compose.yml
##########
@@ -1015,7 +1015,8 @@ services:
command: &csharp-command >
/bin/bash -c "
/arrow/ci/scripts/csharp_build.sh /arrow &&
- /arrow/ci/scripts/csharp_test.sh /arrow"
+ /arrow/ci/scripts/csharp_test.sh /arrow &&
+ /arrow/ci/scripts/csharp_nuget.sh /arrow"
Review comment:
(nit) I think I would call this `csharp_pack.sh`. `pack` is the verb we
use in the tooling: `dotnet build`, `dotnet test`, and `dotnet pack`.
##########
File path: ci/scripts/csharp_nuget.sh
##########
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -eux
+
+source_dir=${1}/csharp
+
+pushd ${source_dir}
+dotnet pack -c Release
+for pdb in artifacts/Apache.Arrow/Release/*/Apache.Arrow.pdb; do
+ sourcelink test ${pdb}
Review comment:
What do you think about putting this in `csharp_test.sh` instead? This
operation is more about testing what was built during `dotnet build` is
correct. It actually doesn't do anything with the artifacts created by `dotnet
pack`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
