jianxind commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r421884749
##########
File path: cpp/src/parquet/encoding_benchmark.cc
##########
@@ -199,6 +199,107 @@ static void BM_PlainDecodingFloat(benchmark::State&
state) {
BENCHMARK(BM_PlainDecodingFloat)->Range(MIN_RANGE, MAX_RANGE);
+static void BM_PlainEncodingSpacedBoolean(benchmark::State& state) {
+ const int num_values = state.range(0);
+ bool* values = new bool[num_values];
+ // Fixed half spaced pattern
+ std::vector<uint8_t> valid_bits(arrow::BitUtil::BytesForBits(num_values),
0b10101010);
Review comment:
Seems can't, the PutSpaced only accept T* input, but Put has
std::vector<T> input.
Does it has a way or necessary to convert a std::vector<bool> to bool*?
virtual void Put(const T* src, int num_values) = 0;
virtual void Put(const std::vector<T>& src, int num_values = -1);
virtual void PutSpaced(const T* src, int num_values, const uint8_t*
valid_bits,
int64_t valid_bits_offset) = 0;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
