kiszk commented on a change in pull request #7136:
URL: https://github.com/apache/arrow/pull/7136#discussion_r422575298
##########
File path: cpp/src/arrow/util/bit_util.h
##########
@@ -990,8 +999,16 @@ class ARROW_EXPORT Bitmap : public
util::ToStringOstreamable<Bitmap>,
if (offsets[i] == 0) {
visited_words[i] = words[i][word_i];
} else {
+#if ARROW_LITTLE_ENDIAN
visited_words[i] = words[i][word_i] >> offsets[i];
visited_words[i] |= words[i][word_i + 1] << (kBitWidth -
offsets[i]);
+#else
Review comment:
The above code assumes the little-endian data layout by using shift
operation to more than one-byte data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
