bkietz commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r425328361
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -42,6 +43,52 @@ def _forbid_instantiation(klass, subclasses_instead=True):
raise TypeError(msg)
+ctypedef CResult[shared_ptr[CRandomAccessFile]] CCustomOpen()
+
+cdef class FileSource:
+
+ cdef:
+ # XXX why is shared_ptr necessary here? CFileSource shouldn't need it
+ shared_ptr[CFileSource] wrapped
Review comment:
@pitrou @kszucs I tried using
```suggestion
CFileSource wrapped
```
which caused a segfault after `FileSource.__init__()`. Am I missing
something obvious?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
