hurricane1026 commented on a change in pull request #7202:
URL: https://github.com/apache/arrow/pull/7202#discussion_r426291038
##########
File path: cpp/src/arrow/array.h
##########
@@ -798,7 +798,12 @@ class ARROW_EXPORT FixedSizeListArray : public Array {
i += data_->offset;
return static_cast<int32_t>(list_size_ * i);
}
+#ifdef _MSC_VER
int32_t value_length(int64_t i = 0) const { return list_size_; }
+#else
+ int32_t value_length(__attribute__((unused)) int64_t i = 0) const { return
list_size_; }
Review comment:
emmm...
because arrow-cpp employ a very not-strictly compiling flags setting, and
got too many warnings in compiling process.
Then I use -isystem arrow_src instead of -I arrow_src in my makefile.
So, if you guys didn't think unused-parameter or other warnings was big
thing, ignoring my PR is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
