pitrou commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r426728550
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -42,6 +43,51 @@ def _forbid_instantiation(klass, subclasses_instead=True):
raise TypeError(msg)
+ctypedef CResult[shared_ptr[CRandomAccessFile]] CCustomOpen()
+
+cdef class FileSource:
+
+ cdef:
+ # XXX why is shared_ptr necessary here? CFileSource shouldn't need it
Review comment:
The Cython object attribute isn't stack-allocated. My point is that, if
it's segfaulting, it's perhaps because default initialization of FileSource,
then assignment, is faulty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
