fsaintjacques commented on a change in pull request #7180:
URL: https://github.com/apache/arrow/pull/7180#discussion_r426804654
##########
File path: cpp/src/parquet/arrow/reader_internal.cc
##########
@@ -747,8 +747,7 @@ Status TypedIntegralStatisticsAsScalars(const Statistics&
statistics,
using CType = typename StatisticsType::T;
return MakeMinMaxScalar<CType, StatisticsType>(statistics, min, max);
default:
- return Status::NotImplemented("Cannot extract statistics for type ",
- logical_type->ToString());
+ return Status::NotImplemented("Cannot extract statistics for type ");
Review comment:
It turns out that this one gave a non-negligible performance boost
because there's a lot of type we don't support, multiply by the number of row
group and columns...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
