pitrou commented on a change in pull request #7221:
URL: https://github.com/apache/arrow/pull/7221#discussion_r427136798
##########
File path: cpp/src/parquet/properties.h
##########
@@ -59,31 +59,32 @@ struct ParquetVersion {
/// DataPageV2 at all.
enum class ParquetDataPageVersion { V1, V2 };
-static int64_t DEFAULT_BUFFER_SIZE = 1024;
-static bool DEFAULT_USE_BUFFERED_STREAM = false;
+/// Align the default buffer size to the page size of most platforms.
+constexpr int64_t kDefaultBufferSize = 4096;
Review comment:
You can bump this to 16384 for slightly better perf. 4096 is really too
small nowadays.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
