rdettai commented on a change in pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#discussion_r427864924
##########
File path: rust/parquet/src/column/reader.rs
##########
@@ -190,15 +190,12 @@ impl<T: DataType> ColumnReaderImpl<T> {
(self.num_buffered_values - self.num_decoded_values) as
usize,
);
- // Adjust batch size by taking into account how much space is
left in
- // values slice or levels slices (if available)
- adjusted_size = min(adjusted_size, values.len() - values_read);
- if let Some(ref levels) = def_levels {
- adjusted_size = min(adjusted_size, levels.len() -
levels_read);
- }
- if let Some(ref levels) = rep_levels {
- adjusted_size = min(adjusted_size, levels.len() -
levels_read);
- }
+ // Adjust batch size by taking into account how much data there
+ // to read. As batch_size is also smaller than value and level
+ // slices (if available), this ensures that available space is
not
+ // exceeded.
+ adjusted_size = min(adjusted_size, batch_size - values_read);
Review comment:
this very much looks to be the reason for your issue yes! Can you
isolate the context in which your error occurred into a test ? I didn't find a
way to do it with my data...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
