kou commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-632946831
We need the following change for macOS. What do you thin about this change?
```diff
diff --git a/cpp/src/arrow/compute/kernel.cc
b/cpp/src/arrow/compute/kernel.cc
index 1d02117cc..2895468c8 100644
--- a/cpp/src/arrow/compute/kernel.cc
+++ b/cpp/src/arrow/compute/kernel.cc
@@ -158,8 +158,8 @@ std::shared_ptr<TypeMatcher>
TimestampUnit(TimeUnit::type unit) {
// ----------------------------------------------------------------------
// InputType
-uint64_t InputType::Hash() const {
- uint64_t result = kHashSeed;
+size_t InputType::Hash() const {
+ size_t result = kHashSeed;
hash_combine(result, static_cast<int>(shape_));
hash_combine(result, static_cast<int>(kind_));
switch (kind_) {
@@ -341,11 +341,11 @@ bool KernelSignature::MatchesInputs(const
std::vector<ValueDescr>& args) const {
return true;
}
-uint64_t KernelSignature::Hash() const {
+size_t KernelSignature::Hash() const {
if (hash_code_ != 0) {
return hash_code_;
}
- uint64_t result = kHashSeed;
+ size_t result = kHashSeed;
for (const auto& in_type : in_types_) {
hash_combine(result, in_type.Hash());
}
diff --git a/cpp/src/arrow/compute/kernel.h b/cpp/src/arrow/compute/kernel.h
index cd59bfa82..f90627ab5 100644
--- a/cpp/src/arrow/compute/kernel.h
+++ b/cpp/src/arrow/compute/kernel.h
@@ -198,7 +198,7 @@ class ARROW_EXPORT InputType {
bool operator!=(const InputType& other) const { return !(*this == other);
}
/// \brief Return hash code
- uint64_t Hash() const;
+ size_t Hash() const;
/// \brief Render a human-readable string representation
std::string ToString() const;
@@ -359,7 +359,7 @@ class ARROW_EXPORT KernelSignature {
bool operator!=(const KernelSignature& other) const { return !(*this ==
other); }
/// \brief Compute a hash code for the signature
- uint64_t Hash() const;
+ size_t Hash() const;
const std::vector<InputType>& in_types() const { return in_types_; }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
