zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429552370



##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -238,5 +238,27 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public 
DatasetFactory {
   util::optional<util::string_view> RemovePartitionBaseDir(util::string_view 
path);
 };
 
+class ARROW_DS_EXPORT SingleFileDatasetFactory : public DatasetFactory {

Review comment:
       I was aware of the changes in ARROW-8318 but at this time I can't 
remember what stops me from removing SingleFileDataset and migrating to 
FileSystemDataset. I'll have another try next week.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to