rymurr commented on a change in pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#discussion_r433727618
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/VectorSchemaRoot.java
##########
@@ -54,7 +54,7 @@
private Schema schema;
private int rowCount;
private final List<FieldVector> fieldVectors;
- private final Map<String, FieldVector> fieldVectorsMap = new HashMap<>();
+ private final Map<Field, FieldVector> fieldVectorsMap = new
LinkedHashMap<>();
Review comment:
I didn't want to lose the type information. This still allows you to
address Field("x", int) compared to Field("x", long).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
