wesm commented on a change in pull request #7310:
URL: https://github.com/apache/arrow/pull/7310#discussion_r433855919



##########
File path: cpp/src/arrow/compute/exec.h
##########
@@ -36,6 +36,7 @@
 namespace arrow {
 
 class Array;
+class BooleanArray;

Review comment:
       Note: IWYU unfortunately doesn't recognize forward declarations 
(https://github.com/include-what-you-use/include-what-you-use/issues/530) but 
we can add mappings to build-support/iwyu/mappings/arrow-misc.imp to attribute 
symbols to type_fwd.h so it won't complain about them. I'll fill up these 
mappings incrementally to help 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to