jorisvandenbossche commented on a change in pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#discussion_r433864179
##########
File path: cpp/src/arrow/compute/function.h
##########
@@ -230,5 +234,19 @@ class ARROW_EXPORT ScalarAggregateFunction
const std::vector<ValueDescr>& values) const;
};
+/// \brief A function that dispatches to other functions. Must override
+/// Function::Execute.
Review comment:
From further reading the code: this indeed is the case (maybe a small
comment explaining this what it means to implement Function:Execute yourself
might be worth it, although people working with the compute API might be
expected to know what the responsibility of `Function:Execute` is)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
