ilijapuaca commented on a change in pull request #7189:
URL: https://github.com/apache/arrow/pull/7189#discussion_r433950238
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -189,6 +189,7 @@ set(ARROW_SRCS
util/utf8.cc
util/value_parsing.cc
vendored/base64.cpp
+ vendored/datetime/ios.mm
Review comment:
I wasn't sure about usage of these files in general -- `ios.h` is
included from `tz.cpp` under `#ifdef __APPLE__`, which implies it's being used
on macOS as well?
I could make this file iOS-specific, but perhaps some additional updates
should be made in order to consolidate `datetime` module and its usage. If that
is the case, I'd need some pointers as I'm not familiar with this portion of
the codebase and its usage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
