jorisvandenbossche commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r434102867
##########
File path: cpp/src/arrow/dataset/discovery.cc
##########
@@ -102,11 +102,10 @@ Result<std::shared_ptr<Dataset>>
UnionDatasetFactory::Finish(FinishOptions optio
return std::shared_ptr<Dataset>(new UnionDataset(options.schema,
std::move(children)));
}
-FileSystemDatasetFactory::FileSystemDatasetFactory(
- std::vector<std::string> paths, std::shared_ptr<fs::FileSystem> filesystem,
- std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options)
- : paths_(std::move(paths)),
- fs_(std::move(filesystem)),
+FileSystemDatasetFactory::FileSystemDatasetFactory(std::vector<FileSource>
sources,
+ std::shared_ptr<FileFormat>
format,
+ FileSystemFactoryOptions
options)
Review comment:
OK, if it is only called like this in a single place, it's indeed easy
to wrap the files in a list of FileSources at the call site
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
