pitrou commented on pull request #7334:
URL: https://github.com/apache/arrow/pull/7334#issuecomment-638059015


   > I added function that tries to create the necessary symlinks when you call 
pyarrow.get_library_dirs()
   
   It's a bad idea to add side effects to a simple inquiry function. This 
should IMHO be in a separate function (e.g. `create_library_symlinks`).
   
   > I don't think we need to ship the tests in the wheels.
   
   I'd like to keep them. It's helpful to test if an installation works 
correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to